Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ErrorHandler: Renaming \Exception to \Throwable because PHP 7 throws Errors to #402

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vcampitelli
Copy link

At Peekmo\AtomAutocompletePhp\ErrorHandler there's a method called onException that was expecting a \Exception object to display the message and die.

Since PHP 7, errors are thrown too, but as an \Error class. Both \Exception and \Error classes implement a \Throwable interface. To make the code more compliant and avoid Fatal Errors due to an unexpected type received, I'm renaming \Exception to \Throwable in that method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant